Miscellaneous cleanups#235
Merged
Merged
Conversation
We previously reused the same variable `status` to store different values without really sharing them. This made the code harder to follow, so this patch just gets rid of that sharing.
awelzel
reviewed
Jul 17, 2026
awelzel
left a comment
awelzel
left a comment
Contributor
There was a problem hiding this comment.
The last commit needs some rework IMO.
bbannier
force-pushed
the
topic/bbannier/cleanups
branch
from
July 17, 2026 08:45
a01b9b0 to
9ba4ca8
Compare
awelzel
approved these changes
Jul 17, 2026
This test was hardcoding the URI of a supposedly non-existent repo on github.com. This not only caused the test to reach out to the internet just to find nothing, but on some systems it also could have lead to the test hanging while waiting for a user password prompt to unlock their keychain. With this patch we now use an definitely non-existing repo which can be validated without reaching out to expensive external APIs. While touching the file we also fix a mispelling of `git commit` as `gitcommit`; this only failed silently and had no effect on the test outcome since the changes were committed with another `git commit` later.
bbannier
force-pushed
the
topic/bbannier/cleanups
branch
from
July 17, 2026 09:14
9ba4ca8 to
c3db68b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a number of unrelated minor issues, see the individual commits for more details.