fix(rpc): mark panicked async operations as failed#466
Open
ouicate wants to merge 1 commit into
Open
Conversation
When a Tokio task spawned by AsyncOperation::new panics, the operation state was never updated from Executing. Ghost operations then persisted indefinitely because z_getoperationresult only prunes terminal states. Await the spawned task's JoinHandle in a companion task and record a Failed result if the task panicked, so clients can observe and prune the operation normally. Co-Authored-By: Cursor <noreply@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AsyncOperation::newpanics, the operation is now transitioned tofailedinstead of remaining stuck inexecutingforever.JoinHandleand records aMiscRPC error if the task panicked, soz_getoperationstatusandz_getoperationresultbehave correctly and ghost operations can be pruned.