fix: Reject oversized memo hex strings before decoding in z_sendmany#464
Open
ouicate wants to merge 1 commit into
Open
fix: Reject oversized memo hex strings before decoding in z_sendmany#464ouicate wants to merge 1 commit into
ouicate wants to merge 1 commit into
Conversation
`hex::decode` allocates decoded bytes before `MemoBytes::from_bytes` enforces the 512-byte limit, so an authenticated RPC caller could trigger unbounded heap allocation via `z_sendmany`'s memo field. Co-Authored-By: Composer <noreply@cursor.com>
ouicate
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_memo:hex::decodeallocated up tomemo_hex.len() / 2bytes beforeMemoBytes::from_bytesenforced the 512-byte limit.hex::decode, matching the existing RPC error message.Related security advisory: GHSA-9w94-x964-rgxq