Skip to content

Fix bug in v2 zarr parser which interprets empty dimension list as truthy - #936

Merged
jbusecke merged 2 commits into
mainfrom
none-iterator-bug
Mar 19, 2026
Merged

Fix bug in v2 zarr parser which interprets empty dimension list as truthy#936
jbusecke merged 2 commits into
mainfrom
none-iterator-bug

Conversation

@jbusecke

@jbusecke jbusecke commented Mar 18, 2026

Copy link
Copy Markdown
Collaborator

What I did

See #935

Acceptance criteria:

@codecov

codecov Bot commented Mar 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.23%. Comparing base (bdc1a3a) to head (512c8d5).
⚠️ Report is 51 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #936   +/-   ##
=======================================
  Coverage   89.23%   89.23%           
=======================================
  Files          33       33           
  Lines        2025     2025           
=======================================
  Hits         1807     1807           
  Misses        218      218           
Files with missing lines Coverage Δ
virtualizarr/parsers/zarr.py 97.50% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Fix `ZarrParser` issue with scalar variable parsing from v2 native zarr stores.
@jbusecke
jbusecke marked this pull request as ready for review March 19, 2026 18:26
@jbusecke
jbusecke merged commit 2b68ec1 into main Mar 19, 2026
18 checks passed
@jbusecke
jbusecke deleted the none-iterator-bug branch March 19, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Zarr Parser fails to parse v2 store with scalar variable in latest main

2 participants