Fix proc/block self binding in emits (v0.5.2)

[sebscholl]

Summary

Patch fix for a bug introduced in 0.5.1 where self inside payload builder blocks and if:/unless: condition procs was bound to the class rather than the service instance.

The bug

emits accepts procs/lambdas for payload building and conditions. These were executed via call, which preserves the proc's original self — the class at definition time. This meant instance variables set in initialize or call were silently unreadable:

emits :event, on: :success, unless: ->(_result) { @suppress }  # always nil — reads class ivar
emits :event, on: :success do |_result| { label: @label } end  # @label always nil

The fix

Switch from builder.call(result) to instance_exec(result, &builder) in both build_event_payload and evaluate_emission_condition. This binds self to the service instance, matching the existing behaviour of Symbol method references.

# Now works correctly
emits :event, on: :success, unless: ->(_result) { @suppress }
emits :event, on: :success do |_result| { label: @label } end

Any code reading only from result (all documented usage prior to 0.5.1) is completely unaffected.

Test plan

• Regression test: condition proc reads instance variable set in initialize
• Regression test: payload builder block reads instance variable set in initialize
• bundle exec rspec — 770 examples, 0 failures
• bundle exec rubocop — no offenses

🤖 Generated with Claude Code