Repository navigation
auth: three ways in, asked for only to publish - #4
Conversation
Google, a six-digit email code, and Sign in with Apple, all landing on the same auth.users row so nothing downstream asks how somebody signed in. Notes still need no account. The gate is two steps -- session, then handle -- and `needed` names whichever is outstanding so nobody is sent to a screen they have already satisfied. Reading the feed is never gated; the prompt on the feed header is a prompt, not a wall. Apple is wired and hidden on Android. It becomes required by App Store 4.8 the moment Google ships, because 4.8's alternative must let users keep their email private and an emailed code cannot -- receiving the address is the mechanism. plan.md decision 4 reasoned correctly for magic-link-only auth and is corrected here. A code rather than a magic link: a link means mail app to browser to deep link back into the app, and that handoff fails often enough to lose people. No passwords at all -- nothing to breach, no reset flow. The profile is now the account wearing a face: profiles.id is auth.users.id, so v5 drops the social_identity table that cached a local answer to a question the session already answers. The handle is never prefilled from the provider; plan-rollout-2 decision 7 allows pseudonymous accounts on purpose. A build with no credentials still launches, still takes notes, still reads the feed, and says so on the sign-in screen. docs/auth.md has the console setup, including the two things that reliably go wrong: using the Android client id where the web one belongs, and shipping without automatic identity linking. Not verified: the OAuth round trips need a dev build on a device with real credentials. Typecheck, lint, migrations and the Android bundle pass. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017DRL4dVgg5oebLSTenQv2G
|
Warning Review limit reached
Next review available in: 11 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (17)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Google, a six-digit email code, and Sign in with Apple, all landing on the same auth.users row so nothing downstream asks how somebody signed in.
Notes still need no account. The gate is two steps -- session, then handle -- and
needednames whichever is outstanding so nobody is sent to a screen they have already satisfied. Reading the feed is never gated; the prompt on the feed header is a prompt, not a wall.Apple is wired and hidden on Android. It becomes required by App Store 4.8 the moment Google ships, because 4.8's alternative must let users keep their email private and an emailed code cannot -- receiving the address is the mechanism. plan.md decision 4 reasoned correctly for magic-link-only auth and is corrected here.
A code rather than a magic link: a link means mail app to browser to deep link back into the app, and that handoff fails often enough to lose people. No passwords at all -- nothing to breach, no reset flow.
The profile is now the account wearing a face: profiles.id is auth.users.id, so v5 drops the social_identity table that cached a local answer to a question the session already answers. The handle is never prefilled from the provider; plan-rollout-2 decision 7 allows pseudonymous accounts on purpose.
A build with no credentials still launches, still takes notes, still reads the feed, and says so on the sign-in screen. docs/auth.md has the console setup, including the two things that reliably go wrong: using the Android client id where the web one belongs, and shipping without automatic identity linking.
Not verified: the OAuth round trips need a dev build on a device with real credentials. Typecheck, lint, migrations and the Android bundle pass.
Claude-Session: https://claude.ai/code/session_017DRL4dVgg5oebLSTenQv2G