Classify single-finger touches in TUI apps to stop phantom clicks - #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A one-finger scroll in mouse-tracking apps sent a full synthetic click (press, motion, release) along with the wheel events, so apps reacted to clicks the user never made; opencode opened its Message Actions dialog mid-scroll and copied text via OSC 52. Single-finger touches are now classified first: a short lift sends one click pair, movement past the tap threshold scrolls with wheel events only, and holding 300 ms before dragging engages app-side selection, matching the press-and-hold rule of normal mode. Two-finger scroll, pinch zoom, pull-down menu, external mice, and normal selection are unchanged.