Fill notch band slots above the first scrollback row - #128
Merged
Conversation
The band now always covers the full k rows of the shrunk top strip: slots with no scrollback row yet emit a plain bg quad instead of leaving a transparent gap that showed raw ambience on notch devices. The band signature hash now also covers the default fg/bg and bg opacity so baked band colors re-fetch on OSC 10/11 and opacity changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the notch band is active but fewer than k rows exist above the viewport, the band rendered only the rows that exist while the top strip still shrank by the full k rows, leaving a transparent slice that showed raw ambience on cutout devices, e.g. near the top of scrollback. The band now always fills all k slots; a slot without a row emits a plain background quad.
The band signature hash now also covers the default fg/bg and background opacity, so baked band colors re-fetch on OSC 10/11 and opacity changes. Also escapes an apostrophe in the Maltese translation that lupdate normalizes.