Pass moduleMain option to generator#316
Open
deathcap wants to merge 1 commit into
Open
Conversation
This was referenced Jan 10, 2016
deathcap
added a commit
to deathcap/jison-plus
that referenced
this pull request
Feb 9, 2016
|
+1 |
|
Yes, please! The default main breaks commonjs modules used in browser ( |
|
Anything missing here? Any way to help? |
ftes
reviewed
Aug 28, 2018
| settings.moduleName = opts.moduleName; | ||
| } | ||
| if (opts.moduleMain) { | ||
| settings.moduleMain = opts.moduleMain; |
There was a problem hiding this comment.
I think it's just a string of source code, isn't it?
|
It would be great to have this, making people stub out |
|
For now it seems I can install the forked version, like this: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows using the
--moduleMainargument with the command-line interface, to define an alternateexports.mainimplementation.Without this change, it is only possible (as far as I can tell) to set
moduleMainthrough the module API but not the CLI. (You can also specify%option moduleMainin the grammar jison input file, but it generates invalid JavaScript then - only appears to be possible set it to "true", but a function is required).Tested this change with
make test, all pass