Repository navigation
feat(review): add the quality floor guard - #12
Merged
Merged
Conversation
…owered bar A review that reads a diff for correctness misses the moves that make the bar easier to clear: a linter silenced on one line, a test skipped or deleted, assertions removed, a stub left in source, a hook bypass added to a script, a coverage threshold nudged down. Each passes CI and reads as progress. spgr-check-quality-floor runs a stdlib scan for exactly those moves over the lines a change added and the files it removed, and the Code Reviewer carries each as a P1 on the xp axis. Exit 2 is unverified, never clean. The Deterministic dispatch tier gains its first quality-bar guard. The rule set follows the floor guard in addyosmani/agent-skills (https://github.com/addyosmani/agent-skills/blob/main/skills/constraint-driven-development/references/floor-guard.md), rewritten for Springer's review contract. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Area 4 of 11: the quality floor guard
New mechanical skill
spgr-check-quality-floorwith a stdlib, diff-scoped scan for a lowered bar: new lint or type suppressions, skipped or focused tests, deleted test files, net assertion loss in a test file, stubs in source, hook bypasses, loosened coverage thresholds.floor: keep <reason>suppresses one line and lists the reason. Exit 0 clean, 1 violation, 2 unverified (never read as clean). Wired into the reviewer XP axis, spgr-review-pr, the Deterministic dispatch tier, and the instance allowlist. 17 tests over a temporary git repo.Note for the reviewer: run on its own branch the guard reports its regex source lines and test fixtures as violations, which is the detector scanning itself.
Source: addyosmani/agent-skills constraint-driven-development.
Stacked PR: merge in order, this one after its base branch. Merge with a merge commit, as the earlier PRs were.
🤖 Generated with Claude Code