fix(autoload): correct bugs in auto-reload, zpmod build, and zi.zsh cleanup#345
Merged
Conversation
- autoload.zsh: use loop variable rm_file (was rm_compiled) in zi-auto-reload - autoload.zsh: drop --autostash from git merge (not a valid option) - autoload.zsh: capture pipestatus[1] from make|tee; drop redundant second make - autoload.zsh: make cp explicit (zpmod.so → zpmod.bundle, no brace expansion) - autoload.zsh: guard --reset recompile message with RECOMPILE_REQUEST existence - docs/README.md: fix thref → href on VIM badge; fix </p></a> → </a></p> - zi.zsh: remove duplicate 'version' entry from ZI[cmd-list] - zi.zsh: fix spelling 'noticable' → 'noticeable' and grammar in zicompinit_fast comment
There was a problem hiding this comment.
Pull request overview
Fixes a set of correctness issues in Zi’s autoload/self-update/module-build paths, plus a couple of small cleanup and documentation fixes identified during review of #341.
Changes:
- Correct
.zi-auto-reloadremoval loop variable usage and fix.zi-self-updategit mergeinvocation. - Fix zpmod build logic to avoid double-building and to correctly detect pipeline failures; tighten copy step.
- Minor cleanup/spelling fixes in
zi.zshand HTML fixes indocs/README.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
zi.zsh |
Removes duplicate version entry from subcommand list and fixes a comment spelling/grammar issue. |
lib/zsh/autoload.zsh |
Fixes auto-reload cleanup, self-update merge options, zpmod build exit-status handling, and recompile-request gating. |
docs/README.md |
Corrects a broken badge link attribute and fixes mis-nested closing tags in the header HTML. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Pull Request closed and locked due to lack of activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix several bugs in
lib/zsh/autoload.zshand clean up minor issues inzi.zsh, identified during code review of #341.Changes
lib/zsh/autoload.zsh:zi-auto-reload: use loop variablerm_file(was incorrectlyrm_compiled).zi-self-update: drop--autostashfromgit merge(not a valid option for merge; only valid for rebase/pull)pipestatus[1]frommake | tee; remove redundant secondmakeinvocation that ran the build twicecpexplicit —zpmod.so → zpmod.bundle(avoid brace expansion ambiguity)--resetrecompile message with[[ -e RECOMPILE_REQUEST ]]checkzi.zsh:versionentry fromZI[cmd-list]noticable→noticeableand grammar inzicompinit_fastcommentdocs/README.md:thref=→href=on VIM badge link</p></a>→</a></p>(mis-nested tags)Related issues
Extracted from #341.
Type of change
fix— bug fix (non-breaking)Checklist
next(notmain)nextbranchzsh -n zi.zsh/ Trunk checks)