Cleanup and Merge of Bitcore-integration#184
Open
nimbosa wants to merge 8 commits into
Open
Conversation
If generated is true, the unspent transaction output is from a coinbase transaction and can only be sent to a shielded address.
Merge convenience rpc calls
lock when selecting anchor
bitcore integration: cleanup and fix of mixed use of tabs and spaces in favor of spaces consistently
Collaborator
|
(keeping it as a separate branch is lighter for most clients, and we are seemingly planning to deprecate it. And it requires |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Weighing in on the rationale to keep this as a separate branch and an analogous release instead of merging back to
master.These two:
seem to be more future-proof approaches,
per the discussion here: bitcoin/bitcoin#10370
as noted by ch4ot1c here: #169