Add SVG logos for TypeScript and JavaScript kernels#108
Open
eunos-1128 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the kernel installation process to ensure that resource files (such as logo images) are included when installing the kernel specification. It also updates the packaging configuration to include these new resource files.
Resource inclusion improvements:
install.pyto copy all files matchinglogo-*from the appropriateresources/jsorresources/tsdirectory into the kernel spec directory during installation, ensuring that logos and other resources are available for the installed kernels.Packaging updates:
package.jsonfile to include all files underpython/resources/**/*in the packaged files, so that resource files are distributed with the package.Dependency and import updates:
glob,pathlib, andshutilininstall.pyto support the new resource file copying logic.After installation, the logo will appear in the Jupyter Lab launcher, as shown in the image below.