Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #603
When a
MultiLineValueis backed by non-contiguous source ranges,Value()cloned the first chunk raw and only ran the decoder on the remaining chunks, so entities/backslash escapes on the first line came back undecoded (x & y\nz & w).WriteToalready decodes every chunk; this makesValue()consistent with it.Change
text/value.go: decode the first chunk before appending the rest.text/value_test.go: new test with two non-contiguous indices holding an entity and a backslash escape, assertingValue()andWriteTo()agree.Verification (go1.25.1, linux/amd64)
master(Value() = "x & y\nz * w", want "x & y\nz * w") and passes with the change.go test -count=1 ./...— all packages ok;cd parser && go test -tags=goldmark_v1_attribute .— ok.go vet ./text/,gofmt -l text/— clean.> [a](/u "x & y\n> z & w"), readingLink.Title.Value(src)): before"x & y\nz & w", after"x & y\nz & w".