Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #584
The v2 footnote renderer collected document references but skipped references inside footnote definitions. A nested reference could therefore point to a definition that was never rendered; physically nested definitions could also cause a panic.
This indexes definitions separately, then follows references reachable from the document. Each newly referenced definition is queued once, so cycles terminate and unused definitions stay hidden. Leaf definitions are not rescanned, and backlinks retain their existing reference-index order.
Parser numbering and the separate v1 ordering question in #410 are unchanged.
Validation
make testpasses with Go 1.25.14, 1.26.8 and 1.27.1, including README examples.go test -race ./...passes.make lintpasses with both root and_benchmark/gomodules in a local workspace; no tracked module files change.make benchran before/after. AddedBenchmarkFootnoteRendermakes the changed extension path reproducible; the default CommonMark benchmark does not link this extension.Ten balanced-order samples of the new 50-note benchmark show the following allocation costs:
The flat case pays a small queue/stack allocation cost. Timings vary across runs, so this is not a general speedup claim.