Skip to content

globbing paths:[] and ignorePaths:[] changed a lot - #351

Open
ssteffl wants to merge 9 commits into
yui:masterfrom
ssteffl:master
Open

globbing paths:[] and ignorePaths:[] changed a lot#351
ssteffl wants to merge 9 commits into
yui:masterfrom
ssteffl:master

Conversation

@ssteffl

@ssteffl ssteffl commented May 22, 2015

Copy link
Copy Markdown

I have a large project with many subdirectories with many javascript files. With the previous globbing syntax I could not ignore certain vendor/3rd party subdirectories or test directories.

I changed the paths:[] and ignorePath:[] config options to interpret the globs as FILES not directories. This made my project filter and find the files properly. I also updated the documentation and ran the tests. The relevant tests to the utils.js file all passed.

This is not perfectly backwards compatible, if you look i had to change the package.json yuidoc config section to paths:[lib/**] instead of paths:[./lib]. But then it worked just as before.

@yahoocla

Copy link
Copy Markdown

CLA is valid!

@okuryu

okuryu commented Jun 17, 2015

Copy link
Copy Markdown
Member

I'm ok with globbing, but I think we should maintain a backward compatibility.

@ssteffl

ssteffl commented Jun 17, 2015

Copy link
Copy Markdown
Author

Yeah I don't care if you accept my pull request. I just want functionality
that allows me to do what I can do in my pull request.

Thanks,
Sam
On Jun 17, 2015 8:54 AM, "Ryuichi Okumura" notifications@github.com wrote:

I'm ok with globbing, but I think we should maintain a backward
compatibility.


Reply to this email directly or view it on GitHub
#351 (comment).

@mixonic

mixonic commented Aug 8, 2015

Copy link
Copy Markdown
Contributor

Ah, I just opened #372 which deals with the performance concerns in getDirs without changing much else. Unsure if that is better @okuryu but we really need some solution for Ember, the sooner the better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants