globbing paths:[] and ignorePaths:[] changed a lot - #351
Open
ssteffl wants to merge 9 commits into
Open
Conversation
|
CLA is valid! |
Member
|
I'm ok with globbing, but I think we should maintain a backward compatibility. |
Author
|
Yeah I don't care if you accept my pull request. I just want functionality Thanks,
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a large project with many subdirectories with many javascript files. With the previous globbing syntax I could not ignore certain vendor/3rd party subdirectories or test directories.
I changed the paths:[] and ignorePath:[] config options to interpret the globs as FILES not directories. This made my project filter and find the files properly. I also updated the documentation and ran the tests. The relevant tests to the utils.js file all passed.
This is not perfectly backwards compatible, if you look i had to change the package.json yuidoc config section to paths:[lib/**] instead of paths:[./lib]. But then it worked just as before.