Skip to content

Create graph_partitions_and_fusion_plans.md#40

Open
shubhusion wants to merge 3 commits into
yuewuo:mainfrom
shubhusion:main
Open

Create graph_partitions_and_fusion_plans.md#40
shubhusion wants to merge 3 commits into
yuewuo:mainfrom
shubhusion:main

Conversation

@shubhusion

Copy link
Copy Markdown

Fixes #34

@shubhusion

Copy link
Copy Markdown
Author

@yuewuo please review this PR for the tutorial documentation of graph partitions.

@yuewuo

yuewuo commented Jun 1, 2024

Copy link
Copy Markdown
Owner

Hi, there are some undefined functions in your tutorial document. For example, what is evolve_to_global_solution? Could you revise it? Thanks.

@shubhusion

shubhusion commented Jun 1, 2024 via email

Copy link
Copy Markdown
Author

@shubhusion

Copy link
Copy Markdown
Author

@yuewuo I have revised the missing functions. Looking forward to your feedback

@yuewuo

yuewuo commented Jun 3, 2024

Copy link
Copy Markdown
Owner

Please do not use ChatGPT to generate placeholder code. It does not help the project...... The documentation should provide tutorial of how to use the library, instead of just printing the actions that are being made. If you would like to contribute to this, please read the Rust code that constructs the fusion plan, and write the Python script to call them. They are already exposed with Python interface but just documentation is missing. If you find any implementation or Python binding is missing, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

documentation of configuring parallel parameters

2 participants