fix(rice-proto): forward TCP AllocateSocket to checklist after gathering#167
Merged
ystreet merged 3 commits intoJul 1, 2026
Merged
Conversation
Always notify checklistset once gathering is complete; add unit test.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #167 +/- ##
==========================================
+ Coverage 86.22% 86.35% +0.12%
==========================================
Files 38 38
Lines 6681 6678 -3
==========================================
+ Hits 5761 5767 +6
+ Misses 920 911 -9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Owner
|
Thanks for the PR. LGTM once the style and clippy issues are fixed. |
Owner
|
clippy is not happy :) |
Contributor
Author
|
@ystreet I've checked locally, all check now should pass :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StreamMut::allocated_socketso connectivity-checkAllocateSocketrequests reach the checklist after local gathering has finished (RFC 6544 TCP ICE).allocated_socket_reaches_checklist_after_gatheringthat reproduces the hang without the fix.Test plan
cargo test -p rice-proto --no-default-features --features std,rustls allocated_socket_reaches_checklist_after_gathering