chore: sync react native localization from platform-localization#94
Closed
platform-localization-pr-bot[bot] wants to merge 2 commits into
Closed
Conversation
| @@ -0,0 +1,10 @@ | |||
| { | |||
There was a problem hiding this comment.
New Locales Remain Unreachable
An af-ZA or sv-SE device locale, or an explicit locale="af" or locale="sv", still resolves to English. The runtime derives supported languages only from localeResources in locales/index.ts, but that registry imports neither new file, so both catalogs are bundled without ever being selected.
File Used: packages/ui/src/i18n/locales/index.ts (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/ui/src/i18n/locales/af.json
Line: 1
Comment:
**New Locales Remain Unreachable**
An `af-ZA` or `sv-SE` device locale, or an explicit `locale="af"` or `locale="sv"`, still resolves to English. The runtime derives supported languages only from `localeResources` in `locales/index.ts`, but that registry imports neither new file, so both catalogs are bundled without ever being selected.
**File Used:** packages/ui/src/i18n/locales/index.ts ([source](packages/ui/src/i18n/locales/index.ts))
How can I resolve this? If you propose a fix, please make it concise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated localization sync from
platform-localization.c1f8b3ec2228e1f011d528ef26b37b0ccce2d0daDistribute React Native LocalizationGreptile Summary
This PR adds two generated native translation catalogs from platform-localization. The main changes are:
Confidence Score: 4/5
Afrikaans and Swedish locale selection needs to be connected to the runtime registry before merging.
afandsvare absent fromlocaleResources.packages/ui/src/i18n/locales/index.ts
Important Files Changed
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "chore: sync react native localization" | Re-trigger Greptile
Context used (10)