Skip to content

chore: sync react native localization from platform-localization#94

Closed
platform-localization-pr-bot[bot] wants to merge 2 commits into
mainfrom
chore/localization-sync-reactnative-20260721-c1f8b3e
Closed

chore: sync react native localization from platform-localization#94
platform-localization-pr-bot[bot] wants to merge 2 commits into
mainfrom
chore/localization-sync-reactnative-20260721-c1f8b3e

Conversation

@platform-localization-pr-bot

@platform-localization-pr-bot platform-localization-pr-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Automated localization sync from platform-localization.

  • Platform: React Native
  • Source ref: c1f8b3ec2228e1f011d528ef26b37b0ccce2d0da
  • Workflow: Distribute React Native Localization

Greptile Summary

This PR adds two generated native translation catalogs from platform-localization. The main changes are:

  • Afrikaans translations for all current native SDK keys.
  • Swedish translations for all current native SDK keys.

Confidence Score: 4/5

Afrikaans and Swedish locale selection needs to be connected to the runtime registry before merging.

  • Both catalogs match the current English key set.
  • The automated sync is allowed to update generated locale JSON.
  • Device and explicit locale selection fall back to English because af and sv are absent from localeResources.

packages/ui/src/i18n/locales/index.ts

Important Files Changed

Filename Overview
packages/ui/src/i18n/locales/af.json Adds the complete Afrikaans catalog, but the locale is missing from the runtime registry.
packages/ui/src/i18n/locales/sv.json Adds the complete Swedish catalog, but the locale is missing from the runtime registry.

Fix All in Claude Code Fix All in Cursor Fix All in Codex

Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
packages/ui/src/i18n/locales/af.json:1
**New Locales Remain Unreachable**

An `af-ZA` or `sv-SE` device locale, or an explicit `locale="af"` or `locale="sv"`, still resolves to English. The runtime derives supported languages only from `localeResources` in `locales/index.ts`, but that registry imports neither new file, so both catalogs are bundled without ever being selected.

Reviews (1): Last reviewed commit: "chore: sync react native localization" | Re-trigger Greptile

Greptile also left 1 inline comment on this PR.

Context used (10)

  • Rule used - Translation JSON under packages/ui/src/i18n/locale... (source)
  • Context used - AGENTS.md (source)
  • Context used - CLAUDE.md (source)
  • File used - docs/contributing/native-i18n.md (source)
  • File used - packages/ui/src/i18n/locales/en.json (source)
  • File used - packages/ui/src/i18n/locales/index.ts (source)
  • File used - docs/adr/0008-sdk-owned-i18next-no-consumer-overrides.md (source)
  • File used - docs/adr/0009-deferred-dom-localization.md (source)
  • File used - docs/adr/0007-app-locale-vs-bible-language-id.md (source)
  • Context used - Be encouraging with your comments. (source)

@@ -0,0 +1,10 @@
{

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 New Locales Remain Unreachable

An af-ZA or sv-SE device locale, or an explicit locale="af" or locale="sv", still resolves to English. The runtime derives supported languages only from localeResources in locales/index.ts, but that registry imports neither new file, so both catalogs are bundled without ever being selected.

File Used: packages/ui/src/i18n/locales/index.ts (source)

Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/ui/src/i18n/locales/af.json
Line: 1

Comment:
**New Locales Remain Unreachable**

An `af-ZA` or `sv-SE` device locale, or an explicit `locale="af"` or `locale="sv"`, still resolves to English. The runtime derives supported languages only from `localeResources` in `locales/index.ts`, but that registry imports neither new file, so both catalogs are bundled without ever being selected.

**File Used:** packages/ui/src/i18n/locales/index.ts ([source](packages/ui/src/i18n/locales/index.ts))

How can I resolve this? If you propose a fix, please make it concise.

Fix in Claude Code Fix in Cursor Fix in Codex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants