chore: sync react native localization from platform-localization#93
Closed
platform-localization-pr-bot[bot] wants to merge 2 commits into
Closed
Conversation
| @@ -0,0 +1,10 @@ | |||
| { | |||
There was a problem hiding this comment.
New Locales Remain Unregistered
When the device or provider locale is af, af-*, sv, or sv-*, the hardcoded resource registry does not recognize either new catalog and falls back to English. Both files need corresponding imports and entries in locales/index.ts so their translations become reachable.
Rule Used: Translation JSON under packages/ui/src/i18n/locale... (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/ui/src/i18n/locales/af.json
Line: 1
Comment:
**New Locales Remain Unregistered**
When the device or provider locale is `af`, `af-*`, `sv`, or `sv-*`, the hardcoded resource registry does not recognize either new catalog and falls back to English. Both files need corresponding imports and entries in `locales/index.ts` so their translations become reachable.
**Rule Used:** Translation JSON under packages/ui/src/i18n/locale... ([source](.greptile))
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated localization sync from
platform-localization.08557a1b740fd7dcd43ccc2cf3527a552a8d0ee5Distribute React Native LocalizationGreptile Summary
This PR syncs two additional native translation catalogs from platform-localization. The main changes are:
Confidence Score: 4/5
Afrikaans and Swedish remain unreachable until the SDK locale registry includes them.
locales/index.tsdoes not import or register either locale.aforsvlocale values therefore fall back to English.packages/ui/src/i18n/locales/index.ts
Important Files Changed
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "chore: sync react native localization" | Re-trigger Greptile
Context used (10)