chore: sync react native localization from platform-localization#91
Closed
platform-localization-pr-bot[bot] wants to merge 2 commits into
Closed
Conversation
Dustin-Kelley
deleted the
chore/localization-sync-reactnative-20260720-1f1db32
branch
July 21, 2026 17:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated localization sync from
platform-localization.1f1db32e40c92aac06c2292c884a1f40828b836fDistribute React Native LocalizationGreptile Summary
This automated sync PR from the
Distribute React Native Localizationworkflow adds two new locale files — Afrikaans (af.json) and Swedish (sv.json) — covering all existing SDK translation keys. The locale JSON content itself follows the expected shape and is correctly generated.af.jsonandsv.jsonare added with all 9 current SDK keys translated; the JSON structure matches existing locales exactly.packages/ui/src/i18n/locales/index.tswas not updated: neitherafnorsvis imported or added tolocaleResources, so the new translations will never be loaded and users on those locales will silently fall back to English.Confidence Score: 3/5
The locale JSON files are well-formed and correctly generated, but the registration step in index.ts was skipped, so the new translations are dead code until that file is updated.
Two new locale files arrive but index.ts is never updated to import them. Any device resolving to af or sv will fall back to English despite translations being bundled — the feature is silently incomplete on every affected user until fixed.
packages/ui/src/i18n/locales/index.ts needs imports for af and sv and entries in localeResources.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A["platform-localization\n(source: 1f1db32)"] -->|"Distribute React Native\nLocalization workflow"| B["af.json ✅ added"] A -->|"Distribute React Native\nLocalization workflow"| C["sv.json ✅ added"] B -->|"needs import + entry"| D["index.ts\nlocaleResources"] C -->|"needs import + entry"| D D -->|"buildSdkResources()"| E["i18next resources\npassed to SDK"] E -->|"user locale = af/sv"| F["❌ Falls back to English\n(af & sv not in localeResources)"] style F fill:#f88,color:#000 style D fill:#ff9,color:#000%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%% flowchart TD A["platform-localization\n(source: 1f1db32)"] -->|"Distribute React Native\nLocalization workflow"| B["af.json ✅ added"] A -->|"Distribute React Native\nLocalization workflow"| C["sv.json ✅ added"] B -->|"needs import + entry"| D["index.ts\nlocaleResources"] C -->|"needs import + entry"| D D -->|"buildSdkResources()"| E["i18next resources\npassed to SDK"] E -->|"user locale = af/sv"| F["❌ Falls back to English\n(af & sv not in localeResources)"] style F fill:#f88,color:#000 style D fill:#ff9,color:#000Reviews (1): Last reviewed commit: "chore: sync react native localization" | Re-trigger Greptile
Context used: