chore: sync react native localization from platform-localization#90
Closed
platform-localization-pr-bot[bot] wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated localization sync from
platform-localization.ec1e7142af9c6aa5fa310c8e964e032313404ad0Distribute React Native LocalizationGreptile Summary
This automated sync from
platform-localizationadds two new locale files — Afrikaans (af.json) and Swedish (sv.json) — each containing the full set of current SDK translation keys. The JSON files themselves are correctly formed and follow the expected schema.af.jsonandsv.jsonare new files generated by the Distribute React Native Localization workflow; their string values look correct and consistent with the existing locale set.packages/ui/src/i18n/locales/index.tswas not updated to import or register the two new locales, so they will not be included insupportedSdkLngsorbuildSdkResources()and users will silently fall back to English at runtime.Confidence Score: 4/5
Safe to merge only after index.ts is updated to register the two new locales; without that fix the shipped translations are unreachable at runtime.
The two new locale JSON files are correctly generated and well-formed. However, index.ts was not updated to import or register af and sv, so the translations will never be served to users whose device locale matches those codes — they will silently get English instead. That is a functional gap introduced by this PR that needs a small fix before the localization work is complete.
packages/ui/src/i18n/locales/index.ts — needs af and sv imports added to localeResources before the new translations go live.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[platform-localization\nsources/common/en.json] -->|Distribute workflow| B[af.json ✅ added] A -->|Distribute workflow| C[sv.json ✅ added] B -->|needs import| D[index.ts\nlocaleResources] C -->|needs import| D D --> E[supportedSdkLngs] D --> F[buildSdkResources] E --> G[i18next runtime] F --> G style B fill:#c8e6c9 style C fill:#c8e6c9 style D fill:#ffccbc%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%% flowchart TD A[platform-localization\nsources/common/en.json] -->|Distribute workflow| B[af.json ✅ added] A -->|Distribute workflow| C[sv.json ✅ added] B -->|needs import| D[index.ts\nlocaleResources] C -->|needs import| D D --> E[supportedSdkLngs] D --> F[buildSdkResources] E --> G[i18next runtime] F --> G style B fill:#c8e6c9 style C fill:#c8e6c9 style D fill:#ffccbcReviews (1): Last reviewed commit: "chore: sync react native localization" | Re-trigger Greptile
Context used: