Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions mtplx/commands/forge_mixed_convert.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,23 +10,26 @@

The predicate is called by ``mlx_lm.utils.quantize_model`` with
``(path, module)``; returning a dict routes those params to ``to_quantized``
and records the per-module entry in ``config["quantization"]``.
and records the per-module entry in ``config["quantization"]``. An override
with ``"quantize": false`` returns ``False`` so sensitive modules remain in
their source precision.
"""

from __future__ import annotations

import argparse
import json
import re
import sys
from typing import Any, Callable

_LAYER_INDEX_RE = re.compile(r"\.layers\.(\d+)\.")


def build_predicate(recipe: dict[str, Any]) -> Callable[[str, Any], bool | dict[str, Any]]:
body_mode = str(recipe.get("body_mode") or "affine")
overrides: list[tuple[str, frozenset[int] | None, dict[str, Any]]] = []
overrides: list[
tuple[str, frozenset[int] | None, bool | dict[str, Any]]
] = []
for entry in recipe.get("module_overrides") or []:
if not isinstance(entry, dict):
raise SystemExit("module_overrides entries must be objects")
Expand All @@ -37,11 +40,15 @@ def build_predicate(recipe: dict[str, Any]) -> Callable[[str, Any], bool | dict[
layer_set = (
frozenset(int(index) for index in raw_layers) if raw_layers is not None else None
)
params = {
"bits": int(entry.get("bits") or 8),
"group_size": int(entry.get("group_size") or 64),
"mode": str(entry.get("mode") or body_mode),
}
params: bool | dict[str, Any]
if entry.get("quantize") is False:
params = False
else:
params = {
"bits": int(entry.get("bits") or 8),
"group_size": int(entry.get("group_size") or 64),
"mode": str(entry.get("mode") or body_mode),
}
overrides.append((suffix, layer_set, params))

def predicate(path: str, module: Any) -> bool | dict[str, Any]:
Expand All @@ -53,7 +60,7 @@ def predicate(path: str, module: Any) -> bool | dict[str, Any]:
match = _LAYER_INDEX_RE.search(path)
if match is None or int(match.group(1)) not in layer_set:
continue
return dict(params)
return dict(params) if isinstance(params, dict) else params
return True

return predicate
Expand Down
18 changes: 18 additions & 0 deletions tests/test_forge_mixed_convert.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,24 @@ def test_predicate_unmatched_module_uses_body() -> None:
assert predicate("language_model.model.layers.5.self_attn.q_proj", None) is True


def test_predicate_quantize_false_preserves_source_precision() -> None:
recipe = {
"body_mode": "affine",
"module_overrides": [
{
"suffix": "linear_attn.in_proj_a",
"quantize": False,
}
],
}
predicate = build_predicate(recipe)
assert (
predicate("language_model.model.layers.5.linear_attn.in_proj_a", None)
is False
)
assert predicate("language_model.model.layers.5.mlp.gate_proj", None) is True


def test_predicate_prefix_agnostic() -> None:
predicate = build_predicate(SPEED_RECIPE)
assert predicate("model.layers.3.linear_attn.out_proj", None) == {
Expand Down