feat(clip-editor): bar loop-region selection + isolation (YON-103)#2
Open
txbrown wants to merge 1 commit into
Open
feat(clip-editor): bar loop-region selection + isolation (YON-103)#2txbrown wants to merge 1 commit into
txbrown wants to merge 1 commit into
Conversation
ClipLengthBar: tap a bar to loop it (isolate), drag to loop a range; triangle handles, orange selected range, inactive bars. SkiaPianoRollGrid draws the loop-region brace and renders the playhead in grid coordinates so it loops within the region.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
YON-103 — Bar loop-region selection (UI library)
Linear: https://linear.app/yonkolevel/issue/YON-103/bar-2-cannot-be-isolated-during-sequencer-playback
ClipLengthBar: tap a bar to loop it (isolate) / drag to loop a contiguous range; triangle handles; orange selected range; inactive unselected bars; current-bar accent.SkiaPianoRollGrid: draws the loop-region brace (track-color fill + edge lines) in grid coordinates, and renders the playhead inside the canvas so it scrolls with content and loops within the region.Tests
jest ClipEditorView— pass (snapshots updated for the new affordances).Related PRs