Skip to content

Browser folders do not query per folder only use a single bulk request - #2074

Draft
BigRoy wants to merge 1 commit into
ui-qt-browser-refactorfrom
ui-qt-browser-refactor-nolazyfolder
Draft

BigRoy wants to merge 1 commit into
ui-qt-browser-refactorfrom
ui-qt-browser-refactor-nolazyfolder

Conversation

@BigRoy

@BigRoy BigRoy commented Sep 17, 2026

Copy link
Copy Markdown
Member

Changelog Description

In browser folder widget - do not query per folder only use the bulk request.

Additional info

Putting the draft up just so we have the intermediate state already, to get the discussion going.

Testing notes:

  1. Browser folder's list should work.

…lders endpoint

+ Add fuzzy text search like the legacy loader has since #2066
@BigRoy
BigRoy requested a review from iLLiCiTiT September 17, 2026 20:39
@BigRoy BigRoy self-assigned this Sep 17, 2026
@BigRoy BigRoy added the type: enhancement Improvement of existing functionality or minor addition label Sep 17, 2026
@ynbot ynbot added the size/M label Sep 17, 2026
self._fetch_children_async(self._root)


class BulkTreeModel(QAbstractItemModel):

@iLLiCiTiT iLLiCiTiT Sep 18, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I'm not sure about reusability of this model. This will work only if you have 1 column, as soon as you add more columns and different filters based on the column this will become unusable.

Also at the end, the class is so big because it has to implement everything what QStandardItemModel does implement for you. But QStandardItemModel allows more flexibility. It would also support using the async task.

For case of folders I'd say you can copy and modify what we have in tools/utils/folders_widget.py and use the async task to reset the items.

@ynbot ynbot moved this to Review In Progress in PR reviewing Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M type: enhancement Improvement of existing functionality or minor addition

Projects

Status: Review In Progress

Development

Successfully merging this pull request may close these issues.

3 participants