Add shell option for spawnCommand on Windows - #1
Open
amir-zeldes wants to merge 1 commit into
Open
Conversation
Resolves spawn EINVAL error on Windows for newer Node.js versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves a spawn EINVAL error on Windows for newer Node.js versions.
This seems to be needed as a result of the Node.js security patches for the "BatBadBut" vulnerability (CVE-2024-27980). On Windows 11, Node.js now throws an EINVAL error if a child process attempts to execute .bat or .cmd files (which the npm scripts use under the hood) without explicitly setting shell: true.
The Node.js update breaks the spawnCommand utility in scripts/dev.mjs for Windows users running recent Node environments (likely v20.12.2+). Adding shell: process.platform === 'win32' to the spawn options evaluates to true on Windows only, and allows the script to execute successfully.
Tested on: Windows 11, Node.js v24.14.0