Fix clip to padded face#106
Merged
Merged
Conversation
12bf977 to
ce9598e
Compare
brawer
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two maths bugs in clip_to_padded_face that caused it to return incorrect values.
norm_uvw.cross(&b_uvw). It is now computed asb_uvw.cross(&norm_uvw)scaled_n * -1_f64which inverted the collision logic for the second endpoint. it passesscaled_nnow.Reproducing the Bug
The PR includes a test case covering two edge cases:
Adding some print statements to that test case (see at the end) i get
on master:
after the fix:
feel free to check out the first commit here to reproduce the failing test, which is fixed by the followup (second) commit. The code mostly follows the C++ implementation again, like returning somewhat nonsense A and B points on no intersection.
the modified test: