Misc bugs#187
Merged
Merged
Conversation
jschueller
commented
Jul 3, 2026
jschueller
commented
Contributor
- SelectionRule.h: Add missing const qualifier on SortEigenvalue::operator() required by std::sort comparator contract
- SimpleRandom.h: Fix platform-dependent integer overflow in LCG PRNG by using consistent unsigned long casts
- Arnoldi.h: Fix use-after-move in constructor where op.rows() was called after std::move(op); use m_op.rows() instead
- PartialSVDSolver.h: Replace raw new/delete with std::unique_ptr to fix exception-safety memory leak and simplify destructor
- DoubleShiftQR.h: Use Index instead of int for matrix dimensions to avoid narrowing conversion from Eigen::Index
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #187 +/- ##
=======================================
Coverage 94.4% 94.4%
=======================================
Files 49 49
Lines 2669 2481 -188
Branches 307 307
=======================================
- Hits 2520 2344 -176
+ Misses 149 137 -12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jschueller
force-pushed
the
misc
branch
2 times, most recently
from
July 3, 2026 14:01
32a73b1 to
0e98463
Compare
- SelectionRule.h: Add missing const qualifier on SortEigenvalue::operator() required by std::sort comparator contract - SimpleRandom.h: Fix platform-dependent integer overflow in LCG PRNG by using consistent unsigned long casts - Arnoldi.h: Fix use-after-move in constructor where op.rows() was called after std::move(op); use m_op.rows() instead - PartialSVDSolver.h: Replace raw new/delete with std::unique_ptr to fix exception-safety memory leak and simplify destructor - DoubleShiftQR.h: Use Index instead of int for matrix dimensions to avoid narrowing conversion from Eigen::Index
Owner
|
Cool. Many thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.