refactor(build): ビルド処理をWebpackからViteへ移行 - #18
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e5b8b70ef7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "author": "yhotta240", | ||
| "license": "MIT", | ||
| "engines": { | ||
| "node": "^22.0.0 || >=24.0.0" |
There was a problem hiding this comment.
Raise the Node 22 minimum to 22.12.0. The lockfile resolves Vite 8.2.2, whose own engine constraint is ^20.19.0 || >=22.12.0, while this range accepts Node 22.0–22.11 and the README recommends any v22.x release. In those accepted environments, installs with engine-strict fail, and other installs leave the build running on an unsupported Node version.
Useful? React with 👍 / 👎.
| this.addWatchFile(contentEntry); | ||
| this.addWatchFile(contentLogger); |
There was a problem hiding this comment.
Avoid hard-coding only the entry point and logger into the parent watch graph. The nested build() is not itself in watch mode, so after src/content/index.ts imports another local module, subsequent edits to that module do not trigger npm run watch; dist/content.js remains stale and no extension reload is sent. This is especially likely in a starter kit where users are expected to extend the content script.
Useful? React with 👍 / 👎.
1 participant
ビルド処理をWebpackからViteへ移行
変更内容：
Webpackについて：
Webpack時点の状態は
legacy/webpackブランチに保持してする．このPRのマージ後，
mainはViteビルドになる．WebpackとViteの両対応は行わない．