ci: run quality checks on release-please branches - #21
Open
hising wants to merge 5 commits into
Open
Conversation
release-please-action was bumped from v4 to v5 by dependabot but the config was not migrated. v5 requires an explicit 'packages' map instead of top-level release-type — without it, release-please matches tags to component '' which doesn't exist in the manifest and processes 0 commits, producing no Release PRs.
release-please PRs are created with GITHUB_TOKEN which doesn't trigger pull_request events, so CI never runs on them. Adding the branch pattern to the push trigger ensures the checks run when release-please pushes its release branch, and the status will be reported on the PR.
- Move npm publish into a second job in release.yml that runs when release-please creates a release. The separate publish.yml triggered on 'release: published' never fires because GITHUB_TOKEN-created releases don't dispatch events to other workflows. - Add include-component-in-tag: false so tags stay v0.6.1 not ui-v0.6.1.
Contributor
Author
|
Also added two more commits to this branch:
|
There was a problem hiding this comment.
Pull request overview
This PR aims to ensure the CI “Quality checks” workflow reports statuses for release-please release PRs by running CI on pushes to release-please-managed branches (which are not covered by the pull_request trigger when created with GITHUB_TOKEN). It also restructures the release-please configuration to a packages (manifest-style) layout.
Changes:
- Extend the CI workflow
pushtrigger to includerelease-please--*branches. - Restructure
release-please-config.jsonto use apackagesmap for the root package (".").
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| release-please-config.json | Moves release-please config into a packages["."] block (manifest-style structure). |
| .github/workflows/ci.yml | Adds release-please--* to the push trigger branch filters to try to get CI statuses on release-please PR head SHAs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
4
to
6
| push: | ||
| branches: [main] | ||
| branches: [main, "release-please--*"] | ||
| pull_request: |
Comment on lines
+3
to
+8
| "packages": { | ||
| ".": { | ||
| "release-type": "node", | ||
| "include-v-in-tag": true, | ||
| "include-component-in-tag": false, | ||
| "bump-minor-pre-major": false, |
Contributor
Author
|
@copilot resolve the merge conflicts in this pull request |
# Conflicts: # release-please-config.json
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release-please PRs are created using
GITHUB_TOKEN, which GitHub prevents from triggeringpull_requestworkflow events (to avoid infinite loops). This means CI never runs on release PRs, leaving them stuck on "Waiting for status to be reported."Fix: add
release-please--*to thepushtrigger. When release-please pushes its branch, CI runs and reports a status back to the PR.🤖 Generated with Claude Code