Skip to content

bump activeadmin and device gems to fix vulnerability [no issue] - #1971

Merged
dmitry-sinina merged 5 commits into
masterfrom
bump-device-gem
Apr 8, 2026
Merged

bump activeadmin and device gems to fix vulnerability [no issue]#1971
dmitry-sinina merged 5 commits into
masterfrom
bump-device-gem

Conversation

@Ivanov-Anton

@Ivanov-Anton Ivanov-Anton commented Mar 29, 2026

Copy link
Copy Markdown
Member

Description

So the main goal for this PR is to fix the devise vulnerability, but when we update this gem, we have a second problem. ActiveAdmin depends on old Devise. Therefore, we update both gems. The current PR has a high risk of creating regression because Devise has changed its major version.

Related commits that should be merged first of all.

activeadmin-plugins/active_admin_scoped_collection_actions#53

  • Bump devise from v4.9.4 to v5.0.3 🚨 (major version changed, here is a link to compare/review changes)
  • Bump activeadmin from v3.2.2 to 3.5.1

Additional links

https://github.com/yeti-switch/yeti-web/security/dependabot/130

@Ivanov-Anton Ivanov-Anton changed the title bump device gem bump activeadmin and device gems Mar 29, 2026
@Ivanov-Anton Ivanov-Anton changed the title bump activeadmin and device gems bump activeadmin and device gems to fix vulnerability Mar 29, 2026
@Ivanov-Anton Ivanov-Anton self-assigned this Mar 29, 2026
@Ivanov-Anton
Ivanov-Anton force-pushed the bump-device-gem branch 3 times, most recently from 7ca30ff to 4acdd3a Compare March 31, 2026 08:02
@Ivanov-Anton Ivanov-Anton changed the title bump activeadmin and device gems to fix vulnerability bump activeadmin and device gems to fix vulnerability [no issue] Mar 31, 2026
@Ivanov-Anton Ivanov-Anton added the Waiting for code review It means that the owner or member of the repositor can do a code review. label Apr 1, 2026
@Ivanov-Anton
Ivanov-Anton requested a review from senid231 April 1, 2026 06:46
@dmitry-sinina

Copy link
Copy Markdown
Contributor

lets wait until active_admin_scoped_collection_actions PR will be merged

@Ivanov-Anton

Copy link
Copy Markdown
Member Author

lets wait until active_admin_scoped_collection_actions PR will be merged

ok you can ping an appropriate team member to make a review.

@dmitry-sinina

Copy link
Copy Markdown
Contributor

https://rubygems.org/gems/active_admin_scoped_collection_actions/versions/2.0.0

Update Gemfile.lock to reflect devise 5.0.3 and new railties >= 7.0 requirement.
Update Gemfile.lock to reflect activeadmin 3.5.1.
@dmitry-sinina
dmitry-sinina merged commit 9eeeec0 into master Apr 8, 2026
14 checks passed
@Ivanov-Anton
Ivanov-Anton deleted the bump-device-gem branch April 8, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Waiting for code review It means that the owner or member of the repositor can do a code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants