fix: collapse the empty catch in the in-process replay state - #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
InProcessProjectionReplayState.NotifyAsync(S108 empty block, S2486 unexplained swallowed exception), both introduced with fix: let a single-process host replay without Redis #43.catch … when (logger is not null)plus a second emptycatchbecome onecatchthat logs through the null-conditional operator, with a comment stating why the exception is swallowed. No behaviour changes: a failing subscriber is logged where a logger exists and never reaches the publisher either way.How it was verified
./scripts/local-gauntlet.sh)