Skip to content

fix: try to avoid could be instantiated with a different subtype of c… #1798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mshima merged 1 commit into from
Apr 29, 2026
+11 −11
Merged

fix: try to avoid could be instantiated with a different subtype of c… #1798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions src/generator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,27 +131,27 @@ export class BaseGenerator<
* }
* };
*/
constructor(args?: string[], options?: O, features?: F);
constructor(args?: string | string[] | O, options?: O | F, features?: F) {
constructor(args?: string[], options?: BaseOptions, features?: BaseFeatures);
constructor(args?: string | string[] | BaseOptions, options?: BaseOptions | BaseFeatures, features?: BaseFeatures) {
super();

args = typeof args === 'string' ? [args] : args;

// Handle backward Compatibility
let actualArgs: string[];
let actualOptions: O;
let actualFeatures: F | undefined;
let actualOptions: BaseOptions;
let actualFeatures: BaseFeatures | undefined;
if (typeof features === 'object') {
actualArgs = args as string[];
actualOptions = options as O;
actualFeatures = features;
actualOptions = options as BaseOptions;
actualFeatures = features as BaseFeatures;
} else if (typeof args === 'object' && !Array.isArray(args)) {
actualArgs = [];
actualOptions = args as O;
actualFeatures = options as F;
actualOptions = args as BaseOptions;
actualFeatures = options as BaseFeatures;
} else {
actualArgs = args ?? [];
actualOptions = options as O;
actualOptions = options as BaseOptions;
}

const { env, ...generatorOptions } = actualOptions;
Expand All @@ -170,7 +170,7 @@ export class BaseGenerator<
}

// Parse parameters
this._initOptions = { ...actualOptions };
this._initOptions = { ...actualOptions } as O;
this._namespace = actualOptions.namespace;
this._namespaceId = toNamespace(actualOptions.namespace);

Expand Down
2 changes: 1 addition & 1 deletion src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export default class Generator<
O extends BaseOptions = BaseOptions,
F extends BaseFeatures = BaseFeatures,
> extends BaseGenerator<C, O, F> {
constructor(arguments_?: string[], options?: O, features?: F) {
constructor(arguments_?: string[], options?: BaseOptions, features?: BaseFeatures) {
super(arguments_, options, features);

// eslint-disable-next-line @typescript-eslint/ban-ts-comment
Expand Down
Loading