Repository navigation
Add GitHub Actions matrix build & release workflows; improve COM wrapper implementations - #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ILicenseInformationobjects.Description
.github/workflows/build.ymlto trigger onpull_request, introduce a matrix fortriplet: [x64-windows, x64-windows-static], uselukka/run-vcpkg@v11, addactions/cache@v4forvcpkg_installedandbuilddirectories, switch to PowerShell shells, and build withcmake --build build --config Release --parallelwhile uploading per-triplet artifacts namedWinDurango-build-${{ matrix.triplet }}..github/workflows/release.ymlthat builds the same matrix on tag pushes (v*), packages per-triplet zips intodist/, and publishes GitHub releases withsoftprops/action-gh-release@v2while supporting manual workflow runs that upload artifacts.README.mdto document the new build and release workflows and explain matrix triplets and release behavior.projects/WinDurango.KernelX/src/CurrentApp.cppto validate out-parameters and returnE_POINTERwhere appropriate, initialize out pointers tonullptr, implementGetIids,GetRuntimeClassName,GetTrustLevelwith sane defaults, implementEraCurrentAppWrapper::get_LicenseInformationto return a newEraLicenseInformationWrapperinstance, and improve error handling and return values across several COM methods.Testing
Codex Task