Fix flaky getAgeData calculations#46
Merged
Merged
Conversation
ksmontville
previously approved these changes
Jun 25, 2026
Emily-ejag
previously approved these changes
Jun 25, 2026
Emily-ejag
approved these changes
Jun 26, 2026
kellyel
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the flaky getAgeData method. Because the calculation involved division using doubles (dividing by ms per year) and time of creation, it would occasionally produce values like 75.9999 instead of 76.00001, and the floored result would return one less
ageMonththan expected. In addition, the if statements are reordered to prioritize the most specific fields.In addition, this removes the dependence on days (parts of code that called
setMonth,new Date(bm, by, currDate.getDate()). If a student's birthday falls on a month with less than 31 days and the run month has 31 days (e.g, September and October), it overflows and the student's birthMonth is one more than expected.