This repository was archived by the owner on Feb 8, 2025. It is now read-only.
WIP: Parallelize tracking#652
Open
arokem wants to merge 4 commits into
Open
Conversation
|
Hello @arokem! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-04-19 18:21:46 UTC |
Contributor
Author
|
One challenge with the parallelization done this way is that I can't seem to be able to use other backends than "threading" because the direction getter and tracker objects that get sent into the parallelized function cannot be pickled by python. I still need to do some more experiments with this to see whether this even provides any performance gains. |
Contributor
Author
|
I should try out pathos, which uses dill to serialize Python objects. Might get past the issues I am seeing here now. |
Contributor
Author
|
I am trying to make the Cython objects in DIPY pickle-able, based on https://ask.sagemath.org/question/8376/pickling-extension-classes/, but still doesn't work yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Along the way, this also fixes a couple of bugs in mask handling in csd/dti, and allows passing an already-initialized direction getter object into the tracking, in case that's a thing you want to do (I use it to inject a bootstrap direction getter into the tracking, without giving it the raw data).