Skip to content

Fix y range with "clipPath"#260

Open
anotherjoshsmith wants to merge 6 commits into
yeatmanlab:masterfrom
anotherjoshsmith:fix-y-range
Open

Fix y range with "clipPath"#260
anotherjoshsmith wants to merge 6 commits into
yeatmanlab:masterfrom
anotherjoshsmith:fix-y-range

Conversation

@anotherjoshsmith

Copy link
Copy Markdown
Contributor

This pull request addresses #256 by setting "clipPath" for subject lines and mean lines/areas. I decided to rework the organization of elements in the plots, so it will be best to hold off on the merge until someone else confirms these changes haven't interfered with any of our linking or functionality.

@richford @akeshavan @arokem @jyeatman Let me know if you notice any issues!

@richford

richford commented Mar 8, 2018

Copy link
Copy Markdown
Collaborator

LGTM. @akeshavan, @arokem, or @jyeatman, could one of you give me a +1 since @anotherjoshsmith reorged a bit and wants to make sure that none of the linking or functionality is broken?

@arokem

arokem commented Mar 8, 2018

Copy link
Copy Markdown
Contributor

This is not supposed to be happening any more, is it?
screen shot 2018-03-08 at 11 06 49 am

You can probably reproduce this by using the following query string (with the template data in our source): ?table[prevSort][count]=2&table[prevSort][order]=ascending&table[prevSort][key]=&table[sort][count]=2&table[sort][order]=ascending&table[sort][key]=MultipleSclerosis&plots[errorType]=std&plots[zoom][rd][scale]=1.9507109230552937&plots[zoom][rd][translate][0]=-33.2050655893036&plots[zoom][rd][translate][1]=-172.63870197496425&plots[zoom][md][scale]=2.1346506760799477&plots[zoom][md][translate][0]=-43.4757823780006&plots[zoom][md][translate][1]=-108.86851606866173&plots[zoom][fa][scale]=1&plots[zoom][fa][translate][0]=0&plots[zoom][fa][translate][1]=0&plots[plotKey]=md&plots[checkboxes][left-corticospinal]=true&plots[checkboxes][callosum-forceps-major]=true&plots[checkboxes][left-ilf]=true&plots[checkboxes][left-arcuate]=true&plots[lineOpacity]=0

@anotherjoshsmith

Copy link
Copy Markdown
Contributor Author

@arokem Good catch! Looks like the clipping for all plots toggles on and off with Right Thalamic Radiation. Probably shouldn't be too tough to fix. I'll take another look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants