Fix y range with "clipPath"#260
Open
anotherjoshsmith wants to merge 6 commits into
Open
Conversation
be78ca3 to
4cb5633
Compare
Collaborator
|
LGTM. @akeshavan, @arokem, or @jyeatman, could one of you give me a +1 since @anotherjoshsmith reorged a bit and wants to make sure that none of the linking or functionality is broken? |
Contributor
Contributor
Author
|
@arokem Good catch! Looks like the clipping for all plots toggles on and off with Right Thalamic Radiation. Probably shouldn't be too tough to fix. I'll take another look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This pull request addresses #256 by setting "clipPath" for subject lines and mean lines/areas. I decided to rework the organization of elements in the plots, so it will be best to hold off on the merge until someone else confirms these changes haven't interfered with any of our linking or functionality.
@richford @akeshavan @arokem @jyeatman Let me know if you notice any issues!