Skip to content

Added observability utility for Tracer and Meter usage#684

Merged
alex268 merged 3 commits into
ydb-platform:masterfrom
alex268:observability
Jul 20, 2026
Merged

Added observability utility for Tracer and Meter usage#684
alex268 merged 3 commits into
ydb-platform:masterfrom
alex268:observability

Conversation

@alex268

@alex268 alex268 commented Jul 20, 2026

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.83%. Comparing base (6ab4366) to head (804db6d).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #684      +/-   ##
============================================
- Coverage     71.87%   71.83%   -0.05%     
- Complexity     3464     3472       +8     
============================================
  Files           389      390       +1     
  Lines         16173    16206      +33     
  Branches       1697     1698       +1     
============================================
+ Hits          11624    11641      +17     
- Misses         3898     3910      +12     
- Partials        651      655       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@robot-vibe-db robot-vibe-db Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Review Summary

Verdict: ❌ 0 critical issues found

Critical issues

No critical issues found.

Other findings

  • Major | Medium: Race condition in Observability.reportTracingUsage/reportMetricsUsage — compound volatile read-modify-write can lose updates — core/src/main/java/tech/ydb/core/impl/Observability.java:24
  • Minor | Medium: buildInfoTest doesn't call transport.close() unlike other tests in the same class — core/src/test/java/tech/ydb/core/impl/YdbTransportImplTest.java:244
  • Minor | Medium: buildInfoTest leaves Observability global state dirty (tracing enabled) with no cleanup in @Aftercore/src/test/java/tech/ydb/core/impl/YdbTransportImplTest.java:244
  • Nit | High: Typo in comment: "calle" should be "calls" — core/src/test/java/tech/ydb/core/impl/YdbTransportImplTest.java:272
  • Nit | High: Missing newline at end of file — core/src/test/java/tech/ydb/core/impl/ObservabilityTest.java:45

This review was generated automatically. Critical issues require attention; other findings are advisory.
If this comment was useful, please give it a 👍 — it helps us improve the review bot.

Comment thread core/src/main/java/tech/ydb/core/impl/Observability.java Outdated
Comment thread core/src/test/java/tech/ydb/core/impl/YdbTransportImplTest.java
Comment thread core/src/test/java/tech/ydb/core/impl/YdbTransportImplTest.java Outdated
Comment thread core/src/test/java/tech/ydb/core/impl/ObservabilityTest.java
@robot-vibe-db

robot-vibe-db Bot commented Jul 20, 2026

Copy link
Copy Markdown

Full analysis log

Analysis performed by claude, claude-opus-4-6.

@alex268
alex268 merged commit ae5b7db into ydb-platform:master Jul 20, 2026
13 checks passed
@alex268
alex268 deleted the observability branch July 20, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants