Added observability utility for Tracer and Meter usage#684
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #684 +/- ##
============================================
- Coverage 71.87% 71.83% -0.05%
- Complexity 3464 3472 +8
============================================
Files 389 390 +1
Lines 16173 16206 +33
Branches 1697 1698 +1
============================================
+ Hits 11624 11641 +17
- Misses 3898 3910 +12
- Partials 651 655 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
KirillKurdyukov
approved these changes
Jul 20, 2026
KirillKurdyukov
previously approved these changes
Jul 20, 2026
There was a problem hiding this comment.
AI Review Summary
Verdict: ❌ 0 critical issues found
Critical issues
No critical issues found.
Other findings
- Major | Medium: Race condition in
Observability.reportTracingUsage/reportMetricsUsage— compound volatile read-modify-write can lose updates —core/src/main/java/tech/ydb/core/impl/Observability.java:24 - Minor | Medium:
buildInfoTestdoesn't calltransport.close()unlike other tests in the same class —core/src/test/java/tech/ydb/core/impl/YdbTransportImplTest.java:244 - Minor | Medium:
buildInfoTestleavesObservabilityglobal state dirty (tracing enabled) with no cleanup in@After—core/src/test/java/tech/ydb/core/impl/YdbTransportImplTest.java:244 - Nit | High: Typo in comment: "calle" should be "calls" —
core/src/test/java/tech/ydb/core/impl/YdbTransportImplTest.java:272 - Nit | High: Missing newline at end of file —
core/src/test/java/tech/ydb/core/impl/ObservabilityTest.java:45
This review was generated automatically. Critical issues require attention; other findings are advisory.
If this comment was useful, please give it a 👍 — it helps us improve the review bot.
|
Analysis performed by claude, claude-opus-4-6. |
KirillKurdyukov
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.