fix: stop stalled Claude turns after inactivity - #327
Open
LucaLow wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a model-inactivity watchdog to the Claude harness turn runner to prevent indefinitely stalled Claude SDK turns, while pausing the watchdog during tool/subagent execution and local processing.
Changes:
- Introduces a default 5-minute Claude model inactivity deadline (
modelInactivityMsoverride) while awaiting SDK initialization and stream activity. - Pauses the inactivity deadline during bridged tool execution and Claude subagent task execution, and resumes/reset logic around SDK
next()waits. - Adds harness-turn tests covering inactivity timeouts, reset behavior, and pausing semantics.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/harness/claude-harness.ts |
Implements the inactivity timer and pause/reset logic around SDK initialization/iteration and tool/subagent execution. |
test/claude-harness-turn.test.ts |
Extends the SDK mock and adds turn tests to validate inactivity timeouts, resets, and pause behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| queue.close(); | ||
| await sdkQuery.interrupt().catch(() => undefined); | ||
| controller.abort(); | ||
| await sdkQuery.interrupt().catch(() => undefined); |
Comment on lines
+314
to
+326
| await new Promise((resolve) => setTimeout(resolve, 15)); | ||
| yield assistantMessage("msg_A", "working", { | ||
| input_tokens: 1, | ||
| output_tokens: 1, | ||
| cache_read_input_tokens: 0, | ||
| cache_creation_input_tokens: 0, | ||
| }); | ||
| await new Promise((resolve) => setTimeout(resolve, 15)); | ||
| yield resultMessage("done"); | ||
| }; | ||
|
|
||
| const harness = createClaudeHarness({ modelInactivityMs: 25 }); | ||
| const { turn } = harnessTurn(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.