Fix OpenSSL genpkey parameter formatting for SSL certificate generation - #76
Merged
Merged
Conversation
The OpenSSL genpkey command was failing with the error: 'Error setting rsa_keygen_bits: 2048 parameter' This was caused by incorrect parameter formatting in the -pkeyopt argument. The parameter 'rsa_keygen_bits: 2048' had a space after the colon, but OpenSSL expects 'rsa_keygen_bits:2048' (no space). This issue was introduced in commit 0b73535 when migrating from genrsa to genpkey for FIPS compatibility. Changes: - Fixed the -pkeyopt parameter in certificate_generator.rb - Updated the corresponding test expectation - Added changelog entry Testing: Verified with OpenSSL command line: openssl genpkey -algorithm RSA -pass stdin -aes256 \ -out /tmp/test.key -pkeyopt rsa_keygen_bits:2048 Successfully generates encrypted key with correct syntax. Fixes: bsc#1266671 Related: bsc#1235462 (FIPS compatibility)
Coverage Report for CI Build 26746178175Coverage remained the same at 98.499%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the OpenSSL genpkey command parameter formatting that was causing SSL certificate generation to fail during the RMT wizard setup.
Problem
The OpenQA test reported the following error:
This was caused by incorrect parameter formatting in the
-pkeyoptargument. The parameterrsa_keygen_bits: 2048had a space after the colon, but OpenSSL expectsrsa_keygen_bits:2048(no space).Root Cause
This issue was introduced in commit 0b73535 when migrating from
genrsatogenpkeyfor FIPS compatibility (bsc#1235462).Changes
-pkeyoptparameter incertificate_generator.rb(removed space after colon)certificate_generator_spec.rbTesting
Verified the fix with OpenSSL command line:
References