Hacktoberfest -- update index.html <html> and <head>#18
Conversation
Added language to <html> tag Added viewport meta data to <head>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
It's very basic thing, try to make some more valuable changes |
HTML - removed inline styles for img in the menu. Added alt to each img tag, for accessibility purposes. CSS - organized, grouped, categorized CSS for readability. Added box-sizing to all. Added styling from HTML to CSS for card images in Menu. Added flex property with justify content set to center for .card-body so images are centered in the menu.
|
I did some more work on this project. Added alt to the img tags. Moved inline styles for img in the menu section to the CSS. Centered the images in the menu. Organized the CSS and gave titles to some sections for readability and ease of use in the code base. |
|
@famanakis Thanks for adding more changes, but you need to resolve conflicts first now. |
|
I think in you should first fetch all the changes done by your fellow contributors and then can do your commits |
|
In a case like this, where there are conflicts -- is it better to delete
the current branch, create a new branch, then pull from the main and make
the changes? or is it better to go through github and make changes
directly to resolve the conflicts?
I have not worked in groups (outside of class) on projects before, so I
appreciate any insight you can provide.
…On Mon, Oct 9, 2023 at 10:02 AM Yash Sinha ***@***.***> wrote:
I think in you should first fetch all the changes done by your fellow
contributors and then can do your commits
Use commands like git pull every time before you start doing some changes
and make sure that your branch is updated every time
—
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARTBPM5KCJ4LUN422HVFPU3X6QNY3AVCNFSM6AAAAAA5WQED2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJTGI4DCMJSGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@famanakis in this kind of situation you need to accept the incoming changes and then should figure out how to merge the code in such a way that the previous changes and your new changes go properly without overlapping |
3 participants
Added language to tag
Added viewport meta data to