fix: update table-of-contents from 0.1.1 to 0.2.5#97
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates the bundled Table of Contents block dependency to pick up an upstream accessibility fix (WCAG 1.3.1) so the subheading collapse/expand toggle is announced with the associated heading text, rather than only a state label.
Changes:
- Bump
@yardinternet/table-of-contentsfrom^0.1.1to^0.2.5. - Update
package-lock.jsonto reflect the new dependency graph (including removal ofreact-css-collapse). - Rebuild the block frontend artifacts (
build/Blocks/table-of-contents/view.js+view.asset.php) to ship the upstream fix.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updates the @yardinternet/table-of-contents dependency version to ^0.2.5. |
| package-lock.json | Locks the new TOC package version and removes now-unused transitive deps (e.g. react-css-collapse). |
| build/Blocks/table-of-contents/view.js | Rebuilt frontend bundle containing the improved accessible naming for the subheading toggle. |
| build/Blocks/table-of-contents/view.asset.php | Updates the generated asset metadata (deps/version) for the rebuilt frontend script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update van
@yardinternet/table-of-contentsvan 0.1.1 naar 0.2.5.Uit de toegankelijkheidsaudit van Moerdijk kwam dat de inklap-knop bij de subkoppen in de inhoudsopgave alleen "Ingeklapt"/"Uitgeklapt" voorleest. Je hoort dus wel de status, maar niet bij welke kop (bv. "Planning") het hoort. In 0.2.5 is dit opgelost: de knop heet nu "Toon/Verberg subhoofdstukken ".
Lokaal getest of het na upgrade werkt, en lijkt goed te gaan.
Geen aanpassingen nodig aan deze plugin zelf. Geen input van gebruiker nodig behalve updaten van plugin.
Na merge: release taggen +
composer updateop Moerdijk en Brave (zelfde oude versie zit in alle 1.5.x).Note *
0.2.5 is wel ESM-only en gebruikt nu de externe JSX-runtime (window.ReactJSXRuntime), maar wp-scripts zet
react-jsx-runtimeal automatisch in de asset-deps.