refactor: remove vendor related css to its own separate folder#155
Open
YvetteNikolov wants to merge 1 commit into
Open
refactor: remove vendor related css to its own separate folder#155YvetteNikolov wants to merge 1 commit into
YvetteNikolov wants to merge 1 commit into
Conversation
YvetteNikolov
requested review from
FreakyWizard,
JasperS20,
Rovasch,
ShunLuk,
SimonvanWijhe,
WybeBosch,
Yannicvanveen,
dtakken,
ictbeheer,
laravdiemen,
mvdhoek1 and
rivanuff
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors theme styling organization by moving plugin/vendor-specific CSS into resources/styles/vendor/ and updating the main frontend stylesheet entrypoint to import from that new location.
Changes:
- Added vendor CSS files for CookieYes, FacetWP, and Gravity Forms under
resources/styles/vendor/. - Updated
resources/styles/frontend.cssto import these styles from./vendor/*instead of./components/*. - Removed the previous component-level imports for these plugin styles from
frontend.css.
Reviewed changes
Copilot reviewed 1 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| web/app/themes/sage/resources/styles/vendor/gravity-forms.css | Introduces Gravity Forms override styles in the new vendor folder. |
| web/app/themes/sage/resources/styles/vendor/facetwp.css | Introduces FacetWP styling/overrides in the new vendor folder. |
| web/app/themes/sage/resources/styles/vendor/cookie-yes.css | Imports CookieYes package CSS and applies theme variable override in the new vendor folder. |
| web/app/themes/sage/resources/styles/frontend.css | Updates frontend entrypoint imports to use the new vendor/ paths (and introduces a vendor import section). |
Comment on lines
+10
to
+13
| /* Vendor */ | ||
| @import './vendor/cookie-yes'; | ||
| @import './vendor/facetwp'; | ||
| @import './vendor/gravity-forms'; |
Contributor
There was a problem hiding this comment.
Alleen gravity-forms moet nog aangepast worden in editor.css idd.
Comment on lines
+10
to
+14
| /* Vendor */ | ||
| @import './vendor/cookie-yes'; | ||
| @import './vendor/facetwp'; | ||
| @import './vendor/gravity-forms'; | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Een opiniated change: alle vendor/plugin gerelateerde css verplaatst naar hun eigen /vendor/ folder.
Het zijn ook eigenlijk geen components, maar CSS direct gerelateerd aan plugins.