[codex] simplify TokChat user roles - #12
Merged
Merged
Conversation
🤖 Augment PR SummarySummary: This PR simplifies TokChat’s user-role model to just Changes:
🤖 Was this summary useful? React with 👍 or 👎 |
| // 字段已存在,忽略 | ||
| } | ||
|
|
||
| normalizeLegacyUserRoles($db); |
There was a problem hiding this comment.
normalizeLegacyUserRoles($db) is executed without a try/catch, so initDatabase() will fail hard if an existing users table predates the role column (or otherwise lacks it). Consider guarding this update similarly to the other migration-style ALTER TABLE blocks so upgrades don’t break on older/corrupt schemas.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
普通用户and系统管理员.sales_reptouser.sales_repandsales_managerrows touserduring database initialization.adminuser-role records displayed as系统管理员.Validation
php -l tools/tokchat/admin.phpphp -l tools/tokchat/api/users.phpphp -l tools/tokchat/api/db.phpuser; legacysales_manageris migrated tousergit diff --check