Repository navigation
ci(release): publish to npm through trusted publishing only - #23
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@yannelli/paseo-be-concisenow has a trusted publisher forrelease.yml(npm trust listshows a GitHub entry with publish permission). This PR removesNODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}from the Publish npm package step, so the workflow publishes through OIDC and holds no npm token. The job already grantsid-token: write, and CI runs npm 11.19.0.docs/npm-publishing.md,docs/INDEX.md, and the README Releases section now describe OIDC-only publishing. The doc also lists thenpm trustcommands to replace the entry if the workflow file is renamed.Merging this PR does not publish to npm, because
ci:does not trigger a release. The first OIDC publish happens on the nextfeat,fix,perf,revert, or breaking-change merge. If that publish fails, fix the trust entry and rerun Release; the step publishes any version missing from npm.After the first OIDC publish succeeds, delete the
NPM_TOKENrepository secret and set the package's Publishing access to require 2FA and disallow tokens.Testing
.github/workflows/release.ymlgrepfinds no remainingNPM_TOKENreference