Repository navigation
Conversation
yannelli
marked this pull request as ready for review
September 15, 2026 22:23
yannelli
marked this pull request as draft
September 22, 2026 02:34
extractPatch only kept the first Begin/End Patch block, so a second heredoc in the same Bash call skipped comment checks. parseApplyPatch also kept reading + lines after End Patch into the last file. Co-authored-by: Ryan Yannelli <ryanyannelli@gmail.com>
cursor
Bot
force-pushed
the
yannelli/fix-apply-patch-spans-b88c
branch
from
October 5, 2026 05:46
54569c0 to
cc756aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Random file sampling (
shuf --random-source=/dev/urandom) landed onapply-patch.mjsandcodex-tests.mjs. Both had real bugs.Production:
extractPatchonly kept the first*** Begin Patch…*** End Patchspan. A Bash command with twoapply_patchheredocs scanned the first file and ignored the rest, so a long comment in the second patch would not be denied.parseApplyPatchalso kept attaching+lines after*** End Patchto the last file, so trailing junk could be treated as file content.Test: the multi-file “reason names the violating file” check printed
FAILbut never incremented the suite failure count, so that assertion could not fail CI.Rebased onto
mainafter the main-only branch flow, so Conventional PR no longer treats this as adev→mainrelease PR.Behavior
parseApplyPatchcloses the current file on*** Begin Patch/*** End Patch, so+lines after the terminator are ignored.ok/badcounters.Checks
Ran locally after the rebase:
scripts/check.mjsreported valid syntax/JSON/versions.node --testpassed 193/193. Plugin tests: 1811 passed, 0 failed. Line coverage 100.00% (5854/5854).check-pr.mjsaccepts this title againstmain.Migration
None.