Skip to content

perf(java): skip formatting pre-formatted proto and grpc directories #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yangyzs wants to merge 1 commit into from
Closed

perf(java): skip formatting pre-formatted proto and grpc directories #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/java.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ jobs:
working-directory: google-cloud-java
run: librarian generate secretmanager
- name: Run librarian generate all (integration test)
if: matrix.task == 'integration' && github.event_name == 'push' && github.ref == 'refs/heads/main'
if: matrix.task == 'integration'
working-directory: google-cloud-java
run: librarian generate --all
create-issue-on-failure:
Expand Down
9 changes: 8 additions & 1 deletion internal/librarian/java/format.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,14 @@ func collectJavaFiles(root string) ([]string, error) {
if err != nil {
return err
}
if d.IsDir() || filepath.Ext(path) != ".java" {
if d.IsDir() {
name := d.Name()
if name == "target" || (strings.HasPrefix(name, ".") && name != ".") || strings.HasPrefix(name, "proto-") || strings.HasPrefix(name, "grpc-") {
return filepath.SkipDir
}
return nil
}
if filepath.Ext(path) != ".java" {
return nil
}
// Exclude generated samples and Spanner-specific sample source directory.
Expand Down
Loading