This repository was archived by the owner on Jan 29, 2021. It is now read-only.
feature: Add "disabled" component prop#3
Open
oprearocks wants to merge 2 commits into
Open
Conversation
Add "disabled" property on the component and pass it down to the select boxes. The main usecase for this would be if users would like to programatically disable the elements using native DOM attributes and not having to go through CSS gymnastics to do that.
The attribute in its current DOM form is null/string but to keep consistency with JavaScript practices it was converted to a Boolean. The Vue.js Template Syntax documentation states that native attributes whose values are falsy (null, undefined or false) will not be rendered. See https://vuejs.org/v2/guide/syntax.html#Attributes for more information.
Author
|
@yangirov , what would be the proper way to test the module? How did you test it? I'd also like to know if I should also run the build script and update the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add "disabled" property on the component and pass it down to the select boxes.
The main usecase for this would be if users would like to programatically disable the elements using native DOM attributes and not having to go through CSS gymnastics to do that.