Skip to content

fix: exclude .codex/** from the self-audit scanner, matching .claude/** - #87

Merged
yanacuti1121 merged 1 commit into
mainfrom
fix-codex-scanner-ignore
Jul 27, 2026
Merged

fix: exclude .codex/** from the self-audit scanner, matching .claude/**#87
yanacuti1121 merged 1 commit into
mainfrom
fix-codex-scanner-ignore

Conversation

@yanacuti1121

@yanacuti1121 yanacuti1121 commented Jul 27, 2026

Copy link
Copy Markdown
Owner

Summary

main's Yana AI Self-Audit job is currently failing (5 critical / 8 high findings) after PR #86 merged .codex/ (agents + hooks mirror) into the repo. All findings are inside .codex/hooks/ — the exact same byte-for-byte content already living in core/hooks/ and .claude/hooks/, which the scanner has never flagged.

Root cause: .yana-aiignore already excludes .claude/** as "internal tooling dirs — scanner infrastructure, not user code" but was never updated to exclude .codex/** the same way when Codex adapter support was added. The findings themselves are the known false-positive class this ignore file already exists to handle — guard-destructive.sh contains destructive-SQL and force-push keywords as its own detection patterns (text it matches against to block them), not code that executes or performs either action.

Verified locally

  • Full-repo scan before this fix: 20 findings under .codex/, 0 under .claude/ for identical content.
  • After adding the ignore entry: 0 findings remain under .codex/.

This is a single-line addition to .yana-aiignore, cherry-picked from the same fix already pushed to the (separately merged) PR #86 branch, onto a clean branch off current main for a minimal, easy-to-review diff.

Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com

Summary by CodeRabbit

  • Cải tiến
    • Cập nhật phạm vi xử lý để bỏ qua toàn bộ nội dung trong thư mục .codex.

PR #86's self-audit CI job failed with 5 critical/8 high findings, all
inside .codex/hooks/ -- the exact same byte-for-byte content already
living in core/hooks/ and .claude/hooks/, which the scanner has never
flagged. Root cause: .yana-aiignore already excludes .claude/** as
'internal tooling dirs -- scanner infrastructure, not user code' but was
never updated to exclude .codex/** the same way when Codex adapter
support was added. The findings themselves are the known false-positive
class this ignore file already exists to handle -- guard-destructive.sh
contains destructive-SQL and force-push keywords as its own detection
patterns (text it matches against to block them), not code that
executes or performs either action.

Verified locally: full-repo scan before this fix showed 20 findings
under .codex/ and 0 under .claude/ for identical content; after adding
the ignore entry, 0 findings remain under .codex/.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@codesandbox

codesandbox Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@cloudflare-workers-and-pages

Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
yana 33bc4b8 Commit Preview URL

Branch Preview URL
Jul 27 2026, 05:50 AM

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e534e85d-3a0b-430f-b7d9-a3b95993dece

📥 Commits

Reviewing files that changed from the base of the PR and between 9579d2e and 33bc4b8.

📒 Files selected for processing (1)
  • .yana-aiignore

📝 Walkthrough

Walkthrough

Cập nhật .yana-aiignore để loại trừ toàn bộ nội dung trong thư mục .codex khỏi phạm vi xử lý.

Changes

Cấu hình phạm vi bỏ qua

Layer / File(s) Summary
Mẫu bỏ qua thư mục .codex
.yana-aiignore
Thêm pattern .codex/** để bỏ qua thư mục .codex cùng toàn bộ nội dung bên dưới.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Poem

Thỏ con nhảy giữa luống cà,
Thấy .codex được bỏ qua rồi.
Dấu sao phủ kín mọi nơi,
Phạm vi gọn lại, vui ơi là vui!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Tiêu đề khớp với thay đổi chính: loại trừ .codex/** khỏi self-audit scanner, tương tự .claude/**.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-codex-scanner-ignore

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yanacuti1121
yanacuti1121 merged commit b7813fb into main Jul 27, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant