chore(browser): Exclude WXT build output from biome - #1800
Merged
Conversation
intent(lint): `npm run lint` failed locally with 14 errors from minified WXT build output that no one edits decision(lint): mirror browser/.gitignore in biome.json — `.output/` and `.wxt/` sit in the same "# Build output" block as `dist/` and `packages/`, but only the latter two were excluded constraint(lint): `.wxt/` is not failing today; it is excluded for the same reason `.output/` is, so a `wxt prepare` artifact cannot reintroduce this Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Biome configuration now excludes ChangesBiome configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
⚡ Performance Benchmark
Details
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1800 +/- ##
=======================================
Coverage 91.87% 91.87%
=======================================
Files 133 133
Lines 5574 5574
Branches 1365 1365
=======================================
Hits 5121 5121
Misses 453 453 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
browser/.outputandbrowser/.wxtto biome's exclude list.Why
biome.jsonincludesbrowser/**and excludesbrowser/distandbrowser/packages, but not.output/or.wxt/. Both sit in the same# Build outputblock ofbrowser/.gitignoreasdist/andpackages/— they are WXT's output fromwxt build/wxt zipandwxt prepare.The result: after running a browser-extension build, root
npm run lintfails with 14 errors frombrowser/.output/{edge-mv3,firefox-mv2}/background.js— minified bundles nobody edits. CI never sees this because it does not build the extension before linting, so it only bites locally..wxt/is not failing today; it is excluded for the same reason, so awxt prepareartifact cannot reintroduce the problem.Verification
npm run lintgoes from 14 errors to exit 0 with the extension build present.Checklist
npm run test— not run; config-only change, no source touchednpm run lint— exit 0🤖 Generated with Claude Code